[service] add warmboot finializer service #2715

yxieca · 2019-03-28T16:55:17Z

DO NOT MERGE UNTIL sonic-net/sonic-utilities#492 is merged and included in master branch. It is however ready for review.

- What I did

After warm reboot is done, we need to disable warm reboot flag and
tear down anything setup for warm reboot and persisted across.

Signed-off-by: Ying Xie ying.xie@microsoft.com

- Required dependencies

[warm-reboot] initialize warm reboot state table before warm rebooting sonic-utilities#492
Advance utilities submodule to include above change.

- How to verify it
continuous warm reboot

After warm reboot is done, we need to disable warm reboot flag and tear down anything setup for warm reboot and persisted across. Signed-off-by: Ying Xie <ying.xie@microsoft.com>

files/image_config/warmboot-finalizer/finalize-warmboot.sh

qiluo-msft · 2019-03-28T22:25:48Z

I suggest revisit the warm-reboot flag design, the complexity become so unnecessary consider the simple requirements. Instead of collaboratively edit DB, we could use a single service or library. The warm-reboot is top-down imperative in concept.

stepanblyschak · 2019-04-01T07:49:23Z

files/image_config/warmboot-finalizer/finalize-warmboot.sh

+function finalize_warm_boot()
+{
+    debug "Finalizing warmboot..."
+    sudo config warm_restart disable


don't need sudo here

Last login: Mon Apr 1 15:22:27 2019 from 10.20.48.209
admin@str-7260cx3-acs-2:$ config warm_restart enable
Root privileges are required for this operation
admin@str-7260cx3-acs-2:$ config warm_restart disable
Root privileges are required for this operation

@yxieca but the service runs as root?

Good point. I guess extra sudo doesn't hurt? :-)

yxieca · 2019-04-01T15:29:03Z

#2725 is created to get this change in 201811 since this PR might be blocked for a while due to unable to move utilities submodule head.

Update sonic-utilities submodule pointer to include the following: * 2ef5b31e [GCU] Add PFC_WD RDMA validator ([sonic-net#2619](sonic-net/sonic-utilities#2619)) * c7aa8416 [show][muxcable] increase timeout for displaying HW_STATUS ([sonic-net#2712](sonic-net/sonic-utilities#2712)) * 2fc2b826 YANG validation for ConfigDB Updates: MIRROR_SESSION use case ([sonic-net#2430](sonic-net/sonic-utilities#2430)) * e16bdaae Fix non-zero status exit on non secure boot system ([sonic-net#2715](sonic-net/sonic-utilities#2715)) * 90d70152 [route_check] implement a check for FRR routes not marked offloaded ([sonic-net#2531](sonic-net/sonic-utilities#2531)) * c2bc150a [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([sonic-net#2714](sonic-net/sonic-utilities#2714)) * a015834d [db_migrator] Add missing attribute 'weight' to route entries in APPL DB ([sonic-net#2691](sonic-net/sonic-utilities#2691)) * cd519aac [ci] Fix pipeline issue caused by sonic-slave-* change. ([sonic-net#2709](sonic-net/sonic-utilities#2709)) * 2680e6f3 [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([sonic-net#2688](sonic-net/sonic-utilities#2688)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>

Update sonic-utilities submodule pointer to include the following: * e6179afa Remove timer from FAST_REBOOT STATE_DB entry and use finalizer ([sonic-net#2621](sonic-net/sonic-utilities#2621)) * ff688323 [route_check] fix IPv6 address handling ([sonic-net#2722](sonic-net/sonic-utilities#2722)) * 7a604c51 update fast-reboot ([sonic-net#2728](sonic-net/sonic-utilities#2728)) * 9f83ace9 [GCU] Add vlanintf-validator ([sonic-net#2697](sonic-net/sonic-utilities#2697)) * 338d1c05 Check SONiC dependencies before installation. ([sonic-net#2716](sonic-net/sonic-utilities#2716)) * 64d2efd2 Improve show acl commands ([sonic-net#2667](sonic-net/sonic-utilities#2667)) * 2ef5b31e [GCU] Add PFC_WD RDMA validator ([sonic-net#2619](sonic-net/sonic-utilities#2619)) * c7aa8416 [show][muxcable] increase timeout for displaying HW_STATUS ([sonic-net#2712](sonic-net/sonic-utilities#2712)) * 2fc2b826 YANG validation for ConfigDB Updates: MIRROR_SESSION use case ([sonic-net#2430](sonic-net/sonic-utilities#2430)) * e16bdaae Fix non-zero status exit on non secure boot system ([sonic-net#2715](sonic-net/sonic-utilities#2715)) * 90d70152 [route_check] implement a check for FRR routes not marked offloaded ([sonic-net#2531](sonic-net/sonic-utilities#2531)) * c2bc150a [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([sonic-net#2714](sonic-net/sonic-utilities#2714)) * a015834d [db_migrator] Add missing attribute 'weight' to route entries in APPL DB ([sonic-net#2691](sonic-net/sonic-utilities#2691)) * cd519aac [ci] Fix pipeline issue caused by sonic-slave-* change. ([sonic-net#2709](sonic-net/sonic-utilities#2709)) * 2680e6f3 [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([sonic-net#2688](sonic-net/sonic-utilities#2688)) Signed-off-by: dprital <drorp@nvidia.com>

Why I did it 832ef9c4 - Fix bug in GCU vlanintf_validator ([Bcm SAI] ugprade Broadcom SAI to version 3.3.5.4m-1 #2765) (5 minutes ago) [jingwenxie] 53f611b7 - Revert "Convert IPv6 addresses to lowercase in apply-patch (Add Pegatron project to branch 201807 #2299)" (Add note for running out of disk space in /var/lib/docker to README.md #2758) (20 hours ago) [jingwenxie] 79a21cef - Revert frr route check ([mlnx] fix url inconsistency in fw.mk #2761) (8 minutes ago) [StormLiangMS] 824680ed - Resolved rc!=0 problem by replacing fgrep with awk. Added ipv4 filtering to get only v4 peers in case of show ip bgp neighbors (Improve eeprom access reliability #2756) (30 hours ago) [saurabh17g] 10f31ea6 - Revert "Replace pickle by json (Add autoneg to 7170-Q59S20 #2636)" ([hostcfgd] Default value of fallthrough for authentication set to be False. #2746) (7 days ago) [Mai Bui] 05fa7513 - Fix the show interface counters throwing exception on device with no external interfaces ([docker-platform-monitor]: Add smartmontools 6.6-1 #2703) (11 days ago) [abdosi] f27dea0c - [route_check] remove check-frr_patch mock ([minigraph]: Mark both ERSPAN and ERSPANv6 as mirror ACL tables #2732) (11 days ago) [Stepan Blyshchak] 2d95529d - Revert "Update load minigraph to load backend acl (mlnx msn2010: default config_db.json generation with sonic-cfggen is not working #2236)" (swss stretch update broke restore_neighbors.py for neigh service #2735) (12 days ago) [Neetha John] c869c970 - (master) Update the ref guide to reflect the vlan brief output ([teamd] update teamd docker to stretch and fix teamd_init failure #2731) (2 weeks ago) [Vivek] 76457141 - Fix fast-reboot DB migration ([teamd]: update teamd docker to stretch #2734) (2 weeks ago) [Aryeh Feigin] f7f783bc - Enhance the logic to wait for all buffer tables to be removed in _clear_qos ([sfputil] Not able to read out values of voltage/temp/power on some cables #2720) (2 weeks ago) [Stephen Sun] e6179afa - Remove timer from FAST_REBOOT STATE_DB entry and use finalizer (Rollback kernel submodule update. #2621) (3 weeks ago) [Aryeh Feigin] ff688323 - [route_check] fix IPv6 address handling ([docker pmon] install fancontrol & sensord #2722) (3 weeks ago) [Stepan Blyshchak] 7a604c51 - update fast-reboot ([201811][sairedis][swss] advance sub module head of sairedis and swss #2728) (3 weeks ago) [jhli-cisco] 9f83ace9 - [GCU] Add vlanintf-validator (Revert "[device/celestica] blacklist gpio_ich kernel module on haliburton" #2697) (3 weeks ago) [jingwenxie] 338d1c05 - Check SONiC dependencies before installation. ([sonic-slave]: Add iproute2 dependencies in stretch docker #2716) (3 weeks ago) [Liu Shilong] 64d2efd2 - Improve show acl commands ([sonic-utilities] update submodule #2667) (3 weeks ago) [bingwang-ms] 2ef5b31e - [GCU] Add PFC_WD RDMA validator ([sub module] advance sonic-utilities sub module for 201811 branch #2619) (3 weeks ago) [isabelmsft] c7aa8416 - [show][muxcable] increase timeout for displaying HW_STATUS (Fixing get_transceiver_change_event #2712) (3 weeks ago) [vdahiya12] 2fc2b826 - YANG validation for ConfigDB Updates: MIRROR_SESSION use case ([mellanox] Update SDK to 4.3.0132 #2430) (3 weeks ago) [isabelmsft] e16bdaae - Fix non-zero status exit on non secure boot system ([service] add warmboot finializer service #2715) (3 weeks ago) [kellyyeh] 90d70152 - [route_check] implement a check for FRR routes not marked offloaded (Feature to run an option platform specific script on the first boot #2531) (3 weeks ago) [Stepan Blyshchak] c2bc150a - [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([swss]: update swss docker to stretch #2714) (3 weeks ago) [Vaibhav Hemant Dixit] a015834d - [db_migrator] Add missing attribute 'weight' to route entries in APPL DB ([device/celestica] blacklist gpio_ich kernel module on seastone #2691) (4 weeks ago) [Vaibhav Hemant Dixit] cd519aac - [ci] Fix pipeline issue caused by sonic-slave-* change. ([201803] Modify Debian apt repos to reflect changes made by maintainers #2709) (4 weeks ago) [Liu Shilong] 2680e6f3 - [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([thrift] add a patch to revert THRIFT-3650 #2688) (4 weeks ago) [Yaqiang Zhu] How I did it How to verify it

[service] add warmboot finializer service

5ef8067

After warm reboot is done, we need to disable warm reboot flag and tear down anything setup for warm reboot and persisted across. Signed-off-by: Ying Xie <ying.xie@microsoft.com>

yxieca added Enhancement ➕ Not Ready to Merge 🕑 Request for 201811 Branch labels Mar 28, 2019

yxieca requested review from jleveque, qiluo-msft and jipanyang March 28, 2019 16:55

jleveque reviewed Mar 28, 2019

View reviewed changes

files/image_config/warmboot-finalizer/finalize-warmboot.sh Show resolved Hide resolved

jleveque approved these changes Mar 28, 2019

View reviewed changes

jipanyang reviewed Mar 28, 2019

View reviewed changes

files/image_config/warmboot-finalizer/finalize-warmboot.sh Show resolved Hide resolved

stepanblyschak reviewed Apr 1, 2019

View reviewed changes

yxieca mentioned this pull request Apr 1, 2019

[201811][service] add warmboot finializer service #2725

Merged

yxieca removed the Request for 201811 Branch label Apr 1, 2019

yxieca removed the Not Ready to Merge 🕑 label Apr 12, 2019

yxieca merged commit f583f57 into sonic-net:master Apr 12, 2019

yxieca deleted the finalizer branch April 12, 2019 22:46

This was referenced Sep 12, 2019

After warm reboot, execution of sudo config reload -y does not restart syncd #2435

Closed

warm restart config table is saved when executing sudo config save -y #2436

Closed

StormLiangMS mentioned this pull request Mar 28, 2023

Advance submodule sonic-utilities to 832ef9c4 #14445

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[service] add warmboot finializer service #2715

[service] add warmboot finializer service #2715

yxieca commented Mar 28, 2019 •

edited

Loading

qiluo-msft commented Mar 28, 2019

stepanblyschak Apr 1, 2019

yxieca Apr 1, 2019 •

edited

Loading

stepanblyschak Apr 1, 2019

yxieca Apr 12, 2019

yxieca commented Apr 1, 2019

[service] add warmboot finializer service #2715

[service] add warmboot finializer service #2715

Conversation

yxieca commented Mar 28, 2019 • edited Loading

qiluo-msft commented Mar 28, 2019

stepanblyschak Apr 1, 2019

Choose a reason for hiding this comment

yxieca Apr 1, 2019 • edited Loading

Choose a reason for hiding this comment

stepanblyschak Apr 1, 2019

Choose a reason for hiding this comment

yxieca Apr 12, 2019

Choose a reason for hiding this comment

yxieca commented Apr 1, 2019

yxieca commented Mar 28, 2019 •

edited

Loading

yxieca Apr 1, 2019 •

edited

Loading